fix (block-div): fix max content width when center aligned #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
|
Size Change: +32 B (0%) Total Size: 2.07 MB
ℹ️ View Unchanged
|
bfintal
requested changes
Jan 26, 2023
There was a problem hiding this comment.
2 things:
-
This seems to be adjusting the width of the block, while the option is for the max content width. This might not produce the expected behavior on smaller screens where the block might get need to be resize smaller.
-
We do not need to conditionally render here because CSS rendering will never trigger a deprecation / block error even if newly added. (please test this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2502